Add ability to run pg_probackup using valgrind #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demonolock
commented
Jun 18, 2025
| @@ -88,6 +89,7 @@ def stream_output(stream: subprocess.PIPE) -> None: | |||
|
|
|||
| return self.process.pid | |||
|
|
|||
| # ---- Start run function ---- # | |||
| def run(self, command, gdb=False, old_binary=False, return_id=True, env=None, | |||
There was a problem hiding this comment.
Я перестала понимать что происходит в run, поэтому немного попилила
demonolock
commented
Jun 18, 2025
| if self.valgrind_sup_path and not os.path.isfile(self.valgrind_sup_path): | ||
| raise FileNotFoundError(f"PG_PROBACKUP_VALGRIND_SUP should contain path to valgrind suppression file, " | ||
| f"but found: {self.valgrind_sup_path}") | ||
| valgrind_cmd = [ |
There was a problem hiding this comment.
Отличие по сути только тут
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.