Skip to content

Presentation compiler still tries to complete package definition #23150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rochala opened this issue May 14, 2025 · 0 comments · Fixed by #23172
Closed

Presentation compiler still tries to complete package definition #23150

rochala opened this issue May 14, 2025 · 0 comments · Fixed by #23172
Assignees
@rochala
Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug Spree Suitable for a future Spree

Comments

@rochala
Copy link
Contributor

rochala commented May 14, 2025

Compiler version

3.7.0

Minimized code

package super.@@ // shows nn + runtimeChecked

Output

nn
runtimeChecked

Expectation

Nothing or package name inferred from directory structure
@rochala rochala added itype:bug Spree Suitable for a future Spree area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools labels May 14, 2025
@rochala rochala self-assigned this May 14, 2025
@rochala rochala mentioned this issue May 15, 2025
Merged
tgodzik pushed a commit that referenced this issue May 22, 2025
@rochala
Fix completion mode filtering + optimize scopeCompletions (#23172)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1eee888 
I've changed scopeCompletions to lazy val to memoize because I beliveve
we don't need to recompute it. The actual fix is at the comment. There
is no need to create a new Completer just to filter all of remaining
completions at later stage.

Fixes #23150
tgodzik pushed a commit to scala/scala3-lts that referenced this issue May 26, 2025
@rochala @tgodzik
Fix completion mode filtering + optimize scopeCompletions (scala#23172)
b96a461 
I've changed scopeCompletions to lazy val to memoize because I beliveve
we don't need to recompute it. The actual fix is at the comment. There
is no need to create a new Completer just to filter all of remaining
completions at later stage.

Fixes scala#23150
tgodzik added a commit to scala/scala3-lts that referenced this issue May 26, 2025
@tgodzik
Fix completion mode filtering + optimize scopeCompletions (scala#23172)
Loading
Loading status checks…
708d541 
I've changed scopeCompletions to lazy val to memoize because I beliveve
we don't need to recompute it. The actual fix is at the comment. There
is no need to create a new Completer just to filter all of remaining
completions at later stage.

Fixes scala#23150
[Cherry-picked 1eee888][modified]
EnzeXing pushed a commit to EnzeXing/dotty that referenced this issue May 27, 2025
@rochala
Fix completion mode filtering + optimize scopeCompletions (scala#23172)
2e3235b 
I've changed scopeCompletions to lazy val to memoize because I beliveve
we don't need to recompute it. The actual fix is at the comment. There
is no need to create a new Completer just to filter all of remaining
completions at later stage.

Fixes scala#23150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rochala rochala

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools itype:bug Spree Suitable for a future Spree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix completion mode filtering + optimize scopeCompletions rochala/dotty
1 participant
@rochala