feat(hub): update version mapping with Proxy v3.4 #1447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloiseleur
reviewed
Jun 11, 2025
mloiseleur
changed the title
mloiseleur
reviewed
Jun 12, 2025
Comment on lines
+188
to
+190
| {{- else if semverCompare "<v3.15.3-0" $version -}} | ||
| {{ $hubProxyVersion = "v3.3" }} | ||
| {{- else if or (semverCompare "=v3.16.0" $version) (semverCompare "=v3.16.1" $version) -}} |
There was a problem hiding this comment.
Suggested change
| {{- else if semverCompare "<v3.15.3-0" $version -}} | |
| {{ $hubProxyVersion = "v3.3" }} | |
| {{- else if or (semverCompare "=v3.16.0" $version) (semverCompare "=v3.16.1" $version) -}} | |
| {{- else if semverCompare "<v3.15.3-0 || >= v3.16.0 < v3.16.2" $version -}} |
There was a problem hiding this comment.
I don't get why this version is better, I prefer my version actually
There was a problem hiding this comment.
I'll try to explain it.
FTM, one condition == one version. So it's quite simple.
With multiple conditions for the same version, it makes it more complex.
There was a problem hiding this comment.
@mloiseleur I agree with @lbenguigui, having one condition per Hub minor version to check seems more understandable for maintenance.
mloiseleur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the Traefik Hub / Traefik Proxy version mapping.
Motivation
Keep the mapping up to date.
More
make testand all the tests passed