Skip to content

separate pythonClassName from pythonFunction #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

koka831
Copy link
Contributor

@koka831 koka831 commented Jul 8, 2017

Ref: #18
This is the enhancement to separate classname from function name.
about regexp of pythonClassName, I intend to make it compliant with pep.

@nfnty
Copy link
Member

nfnty commented Jul 28, 2017

Thanks, waiting for the improved regex.

@koka831
Copy link
Contributor Author

koka831 commented Jul 31, 2017

now I created g:python_highlight_class_names highlight option, which is enable by default.
and add some testcases to make sure class name starts with Capital.
review me again, please.

@terminalnode
Copy link

Layman here so I don't think I'm qualified to leave an actual review, but I tried this and it works well for me.

I changed the color to Special because that works better in my theme, but everything seems to work as expected.

@richin13
Copy link

Works great, @nfnty any specific reason to not merge this?

@koka831
Copy link
Contributor Author

koka831 commented Feb 24, 2019

@nfnty may I ask you, what do you mean by

the improved regex

If this PR don't work as expected, I'll fix it.

@ckudera
Copy link

ckudera commented Jan 4, 2020

Any updates on this PR? Works fine for me.

@nfnty nfnty closed this in 83d4c63 Dec 2, 2020
@nfnty
Copy link
Member

nfnty commented Dec 2, 2020

Thanks!

cdonovick pushed a commit to cdonovick/python-syntax that referenced this pull request Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants