syntax: highlight function calls

[antoinemadec]

First, thanks for the great plugin!

I got inspired by this issue: sheerun/vim-polyglot#283
Changes are minimal, I also updated the doc and README

Thanks,
Antoine

[antoinemadec]

@nfnty , could you please take a look at this pull request?
The changes are minimal, thanks in advance 😃

[nfnty]

Thanks! I refactored it a bit to reduce complexity and to not interfere with other syntax.

[antoinemadec]

@nfnty I just updated your plugin and it seems your commit is breaking the highlighting: function definition, function calls and builtin function now have the same color.
before 53ea235:

after 53ea235:

mine:

Was this intentional?

Thanks,
Antoine

[nfnty]

Yeah, my bad. Should be fixed now.

[antoinemadec]

@nfnty thanks a lot for the quick response. The builtin function highlighting is now fixed.
However, function definition class definition and function calls now all have the same color.
Would it be possible to have:

• function definition and class definition with one highlighting (the same as before my PR)
• function call with another highlighting

After f73fbf0:

Thanks,
Antoine

[nfnty]

Yes, just change the highlight link for pythonFunctionCall.

hi link pythonFunctionCall Identifier

Replace Identifier with whatever highlight group you want.

[antoinemadec]

@nfnty got it. However, your latest commit also changes the class definition and the function definition highlight as shown on my screenshots. Is this intended?

[nfnty]

If you've manually changed the highlight group of pythonFunction before, then it's a side effect of changing the name into pythonFunctionContained. You just have to replace it in your config.

[nfnty]

Nvm, I changed the naming back to what it was before for backward compatibility. Just update to the latest commit and you'll be good to go.

[antoinemadec]

@nfnty , it's working like a charm now 😃
Sorry about all the back and forth and, again, thank you so much for the prompt response and for this great plugin.

Cheers,
Antoine