next(false) in beforeEach pushes state when using the browser forward button

[eyalhakim]

Version

3.0.1

Reproduction link

https://codesandbox.io/s/vue-routing-example-mjmxd

Steps to reproduce

Click on "goodbye"
Click back in browser
Click forward in browser

last url is pushed into history

What is expected?

In ensureUrl, we need to pass false instead of true to make sure current (out-of-sync) url is replaced and not pushed to history

What is actually happening?

The next function passes true to the ensureUrl function thus making it push the out-of-sync url to history

[WarisR]

Hi, do you guys have a workaround for this issue?

[WofWca]

@eyalhakim Did you modify the reproduction example? Can't reproduce.

[WofWca]

In my very specific case it is not next(false), but next(otherRoute).
What I did is I mutated the to argument, then called next() with no arguments.

beforeEnter(to, from, next) {
  if (!isCool(to)) {
    mutateMakeCool(to);
    // Instead of this:
    // const newTo = getCool(to);
    // return next(newTo);
  }
  next();
}