You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
changed the title [-]Do not warn SA1001 (Commas should be spaced correctly) if it follows a preprocessor directive[/-][+]Do not warn SA1001 (Commas should be spaced correctly) if comma follows a preprocessor directive[/+]on Mar 9, 2024
Given that there is a suitable alternative form that avoids the warning, I'm fine with this being closed if you don't think it is needed. I prefer the suggested workaround anyway, the leading comma bothered me haha.
I'm leaving this open because it's fairly standard for us to ignore the end-of-line/beginning-of-line rules in the presence of preprocessor directives. We could either ignore all directives here, or we could just ignore conditional directives (#if/#elif/#else/#endif). I think I lean towards the latter.
Activity
[-]Do not warn SA1001 (Commas should be spaced correctly) if it follows a preprocessor directive[/-][+]Do not warn SA1001 (Commas should be spaced correctly) if comma follows a preprocessor directive[/+]sharwell commentedon Mar 11, 2024
This is fine to fix. Can also likely work around:
Or:
mikernet commentedon Mar 12, 2024
Good point, didn't think of that tbh.
Another one, before:
After:
That works for me.
mikernet commentedon Mar 12, 2024
Given that there is a suitable alternative form that avoids the warning, I'm fine with this being closed if you don't think it is needed. I prefer the suggested workaround anyway, the leading comma bothered me haha.
sharwell commentedon Mar 18, 2024
I'm leaving this open because it's fairly standard for us to ignore the end-of-line/beginning-of-line rules in the presence of preprocessor directives. We could either ignore all directives here, or we could just ignore conditional directives (
#if
/#elif
/#else
/#endif
). I think I lean towards the latter.