Skip to content

SA1402 Should not apply to file-scoped types #3803

Open
@RenderMichael

Description

@RenderMichael

The following code should not give a warning

public sealed class C
{
}

file static class CHelpers
{
}

Activity

bjornhellander

bjornhellander commented on Feb 26, 2024

@bjornhellander
Contributor

Seems like a reasonable request to me, since this situation is why the file modifier was added

added a commit that references this issue on Jul 31, 2024
b59544c
6bee

6bee commented on Jul 31, 2024

@6bee

Please merge PR #3879 to resolve this issue.

added a commit that references this issue on Aug 3, 2024
4e322a4
added 2 commits that reference this issue on Aug 26, 2024
694574c
1cbb532
added 4 commits that reference this issue on Aug 30, 2024
a87e793
c4b4ac9
06ec4fb
9bff5a2
6bee

6bee commented on Feb 4, 2025

@6bee

There has been a ready-to-merge PR to resolve this issue, waiting for six month, that has not even been looked at. If maintenance for this project/repo has been abandoned, please mention it in the readme so people no longer need to bother.

julealgon

julealgon commented on Feb 4, 2025

@julealgon

@sharwell can you provide a position on this? Is there a reason these small changes are kept waiting for months without being merged?

smaillet

smaillet commented on Jun 11, 2025

@smaillet

There has been a ready-to-merge PR to resolve this issue, waiting for six month, that has not even been looked at. If maintenance for this project/repo has been abandoned, please mention it in the readme so people no longer need to bother.

Actually, now it's been almost a year, and still no progress... If this was a patient, I expect its death would have been called by now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @julealgon@bjornhellander@RenderMichael@6bee@smaillet

      Issue actions

        `SA1402` Should not apply to file-scoped types · Issue #3803 · DotNetAnalyzers/StyleCopAnalyzers