Ci: MacOS CI testing #167
Open
Ci: MacOS CI testing #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the NIO dependency. It is breaking because it removes all Swift NIO-isms that were present in the public APIs (like EventLoopFuture and EventLoopGroup argument/return types).
The intent is to replace it with swift-distributed-tracing integration.
This resolves the race condition caused by the inbox counts and the event delivery. If event delivery happens before the subsequent publish increments the inbox counts, then the counts will be lower than expected. Resolved by just not asking for inbox counts, since they aren't relevant to the test.
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
5 times, most recently
from
8b2ea2e to
dc8afc7
Compare
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
from
7317fe6 to
5db3fd0
Compare
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
8 times, most recently
from
a7a6b63 to
84e8911
Compare
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
from
84e8911 to
321dfa1
Compare
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
from
f9028ee to
9ec86f0
Compare
NeedleInAJayStack
force-pushed
the
ci/macos-ci-testing
branch
from
9ec86f0 to
3bc7e46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a dummy MR to try to diagnose MacOS CI issues