Fix JSX comment duplication in preserve mode #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where comments adjacent to JSX expressions were duplicated in the output when using
jsx: preserve
mode.Problem
When TypeScript compiled JSX with comment-like text content, it would duplicate the comments:
Root Cause
The issue occurred because:
/*pre*/
was correctly parsed and emitted as literal textSolution
Modified
forEachTrailingCommentToEmit
in the emitter to add JSX-aware filtering. The fix prevents comment emission when the comment range falls within a JSX text node, avoiding the duplication while preserving all other comment handling behavior.Verification
The fix ensures that JSX text content containing comment-like patterns is no longer incorrectly treated as separate comments by the emitter.
Fixes #11.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.