Skip to content

V3 TIFF : Allow additional and undefined extra samples #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Backport of #2941 for V3

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports support for additional and undefined extra samples in TIFF images. The changes include:

  • Adding a new test image constant and theory test for extra samples.
  • Adding a new enum member to handle CorelDRAW-specific unassociated alpha data.
  • Updating the TIFF decoder options parser to handle the new extra sample type.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/ImageSharp.Tests/TestImages.cs Added constant for extra samples test image
tests/ImageSharp.Tests/Formats/Tiff/TiffDecoderTests.cs Added new test case for extra samples
src/ImageSharp/Formats/Tiff/TiffExtraSampleType.cs Introduced CorelDrawUnassociatedAlphaData enum value
src/ImageSharp/Formats/Tiff/TiffDecoderOptionsParser.cs Modified logic to parse TIFF extra sample data and patch CorelDRAW values

@JimBobSquarePants JimBobSquarePants merged commit 9c011b7 into release/3.1.x Jun 12, 2025
8 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/v3-tiff-extra-samples branch June 12, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant