Skip to content

Query callback function typing is broken in latest v4 release #9240

@cietho

Description

@cietho

Describe the bug

The latest release for @tanstack/react-query v4 breaks the typing of query callback functions onSuccess and onSettled. Instead of infering the typing from the queryFn result, the type is any.

Your minimal, reproducible example

cietho@c8e8ced (Basically you can just checkout the tagged v4.39.1 branch and try to build the typescript examples)

Steps to reproduce

  1. Install @tanstack/react-query@4.39.1
  2. Write a query using TypeScript
  3. Type the queryFn response
  4. Try to access the data returned by queryFn in a typesafe way

Expected behavior

As a developer, I expected the data to be typed as the return type of the queryFn but I am seeing data being typed as any.

How often does this bug happen?

None

Screenshots or Videos

Image

Platform

  • macOS

Tanstack Query adapter

react-query

TanStack Query version

v4.39.1

TypeScript version

v4.8.3 and v5.8.3

Additional context

No response

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions