Skip to content

Fix: Buttons on Edit Media screen have smaller height than other buttons #8963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

hbhalodia
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/63559

  • After Fix:
Screenshot 2025-06-12 at 11 53 30 AM

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jun 12, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@@ -974,7 +974,7 @@ border color while dragging a file over the uploader drop area */
.image-editor .imgedit-menu .button {
display: inline-block;
width: auto;
min-height: 28px;
min-height: 30px;
font-size: 13px;
line-height: 2;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
line-height: 2;
line-height: 2.15384615; /* 28px */

The image editing buttons probably should change the line-height too. r46866 updated both the line-height and max-height for .wp-core-ui .button and more elements. (The other two pixels are the top and bottom border.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will update the line height as well.

After Updating line height,

Screenshot 2025-06-12 at 3 45 10 PM

@hbhalodia
Copy link
Author

Hi @sabernhardt, I have updated the PR to use the 28px line height.

@hbhalodia hbhalodia changed the title Fix: Buttons on edit media screen have samll height which are not consitent with other buttons Fix: Buttons on Edit Media screen have smaller height than other buttons Jun 12, 2025
@hbhalodia hbhalodia requested a review from sabernhardt June 12, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants