code quality: add explicit : void
to method signatures in wp-signup.php, WP_Posts_List_Table, and WP_Screen
#8965
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the method signatures of several functions and files to enforce a
: void
return type. Changes are non-breaking and unlikely to disrupt other open PRs.More specifically:
final
class (cant be extended)While surfaced and part of PHPStan efforts (https://core.trac.wordpress.org/ticket/61175 / #7619 ), this PR serves as proof of concept for a larger proposal that would see
: void
return types implemented across the codebase in a nondisruptive manner while lay the groundwork for safely implementing other return types to existing method signatures.Trac ticket: https://core.trac.wordpress.org/ticket/63558
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.