Skip to content

test(@angular/build): reset project metadata before each run #30571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025

Conversation

alan-agius4
Copy link
Collaborator

Prevents test flakiness caused by useProject not cleaning up metadata between runs.

Prevents test flakiness caused by `useProject` not cleaning up metadata between runs.
@alan-agius4 alan-agius4 requested a review from clydin June 20, 2025 07:40
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 20, 2025
Workaround for piscinajs/piscina#816

Addresses
```
    error properties: Object({ generatedMessage: true, code: 'ERR_ASSERTION', actual: 1, expected: 0, operator: 'strictEqual' })
        at Timeout._onTimeout (/home/runner/.cache/bazel/_bazel_runner/f47b8283cc0f5922f9455b06771398a1/sandbox/processwrapper-sandbox/3878/execroot/_main/bazel-out/k8-fastbuild/bin/packages/angular/build/application_integration_tests_/application_integration_tests.runfiles/_main/node_modules/.aspect_rules_js/piscina@5.1.1/node_modules/piscina/src/index.ts:447:16)
        at listOnTimeout (node:internal/timers:608:17)
        at processTimers (node:internal/timers:543:7)
```
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 20, 2025
@alan-agius4 alan-agius4 merged commit 8cccf38 into angular:main Jun 20, 2025
30 of 31 checks passed
@alan-agius4 alan-agius4 deleted the use-meta branch June 20, 2025 13:39
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants