Skip to content

Conversation

sureshanaparti
Copy link
Contributor

@sureshanaparti sureshanaparti commented May 16, 2025

Description

This PR fixes some typos (no logical changes).

VmwareManager - _managemetPortGroupName => _managementPortGroupName

NetUtils - isNetowrkASubsetOrSupersetOfNetworkB() => isNetworkASubsetOrSupersetOfNetworkB()

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@sureshanaparti sureshanaparti requested a review from Copilot May 16, 2025 13:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects several typographical errors in method and variable names to improve code clarity.

  • Fixed misspelling in a test method name in NetUtilsTest.
  • Corrected a method name in NetUtils.
  • Renamed a variable in VmwareManagerImpl for consistency.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java Fixed typo in test method name
utils/src/main/java/com/cloud/utils/net/NetUtils.java Corrected misspelling in method name
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java Renamed variable to fix typo and improve clarity

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (13ab8a0) to head (b4c9a2e).
Report is 6 commits behind head on 4.19.

Files with missing lines Patch % Lines
...d/hypervisor/vmware/manager/VmwareManagerImpl.java 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              4.19   #10882       +/-   ##
============================================
+ Coverage     4.28%   15.17%   +10.88%     
- Complexity       0    11345    +11345     
============================================
  Files          371     5416     +5045     
  Lines        29724   475621   +445897     
  Branches      5215    58054    +52839     
============================================
+ Hits          1274    72164    +70890     
- Misses       28305   395384   +367079     
- Partials       145     8073     +7928     
Flag Coverage Δ
uitests 4.28% <ø> (-0.01%) ⬇️
unittests 15.89% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@rohityadavcloud rohityadavcloud added this to the 4.19.3 milestone May 16, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13415

@sureshanaparti
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13429

@sureshanaparti
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13340)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49143 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10882-t13340-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 136.42 test_vm_life_cycle.py
test_01_secure_vm_migration Error 136.42 test_vm_life_cycle.py

@rohityadavcloud rohityadavcloud modified the milestones: 4.20.2, 4.19.3 May 22, 2025
@rohityadavcloud
Copy link
Member

This is purely cosmetics change.

@rohityadavcloud rohityadavcloud merged commit 6e19c07 into apache:4.19 May 22, 2025
25 checks passed
@rohityadavcloud rohityadavcloud deleted the typos-fix branch May 22, 2025 06:11
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants