-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix build after forward merge #11010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11010 +/- ##
============================================
- Coverage 17.50% 16.60% -0.90%
Complexity 13925 13925
============================================
Files 5318 5730 +412
Lines 474635 508082 +33447
Branches 55750 61770 +6020
============================================
+ Hits 83066 84386 +1320
- Misses 382288 414260 +31972
- Partials 9281 9436 +155
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GHA and BO build successful. Thanks @shwstppr
Awesome work, congrats on your first merged pull request! |
Description
Fixes UI build after 4.20 forward merge
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?