Skip to content

[Vmware to KVM Migration] Display virt-v2v and ovftool versions for supported hosts for migration #11019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 4.20
Choose a base branch
from

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Jun 12, 2025

Description

This PR extends the VMware to KVM Migration tool by displaying the virt-v2v and ovftool versions (when available) on the UI and storing them as host details.

  • Display versions on the host details view:
    image

  • Display versions on the VMware to KVM Migration tool conversion host selection:

Screenshot 2025-06-12 at 16 38 57

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested on KVM env with 2 Ubuntu 24.04 hosts:

  • Installed virt-v2v in one host -> Verified only virt-v2v version is listed when selecting a host for migration
  • Installed ovftool on the same host -> Verify also ovftool is displayed when selecting a host for migration

Also tested on Oracle Linux 8.6 hosts to verify different versions

How did you try to break this feature and the system with this change?

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13757

@nvazquez nvazquez closed this Jun 13, 2025
@nvazquez nvazquez reopened this Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (8f2735a) to head (9d5cff2).

Files with missing lines Patch % Lines
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 19 Missing ⚠️
...java/com/cloud/agent/manager/AgentManagerImpl.java 0.00% 12 Missing ⚠️
...m/resource/wrapper/LibvirtReadyCommandWrapper.java 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #11019      +/-   ##
============================================
- Coverage     16.15%   16.15%   -0.01%     
+ Complexity    13273    13271       -2     
============================================
  Files          5657     5657              
  Lines        497898   497934      +36     
  Branches      60374    60384      +10     
============================================
  Hits          80435    80435              
- Misses       408505   408540      +35     
- Partials       8958     8959       +1     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13791

@nvazquez nvazquez marked this pull request as draft June 17, 2025 13:44
@nvazquez nvazquez marked this pull request as ready for review June 18, 2025 02:49
@nvazquez
Copy link
Contributor Author

@blueorangutan package

2 similar comments
@kiranchavala
Copy link
Contributor

@blueorangutan package

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13828

@kiranchavala
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13560)

Copy link
Contributor

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Tested both on Debian and Rhel based os

virt-v2v --version and ovftool --version are displayed under host details and during import

Screenshot 2025-06-19 at 10 17 44 AM
Screenshot 2025-06-19 at 10 17 35 AM
Screenshot 2025-06-19 at 10 17 25 AM
Screenshot 2025-06-19 at 10 17 13 AM

@sureshanaparti
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13561)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants