Skip to content

Switch BouncyCastle dependencies to jdk18on for improved security #11034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sroopsai
Copy link

Description

This PR fixes #10954

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.60%. Comparing base (6aaaa83) to head (7827812).

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11034   +/-   ##
=========================================
  Coverage     16.60%   16.60%           
  Complexity    13925    13925           
=========================================
  Files          5730     5730           
  Lines        508224   508224           
  Branches      61789    61789           
=========================================
  Hits          84388    84388           
  Misses       414401   414401           
  Partials       9435     9435           
Flag Coverage Δ
uitests 3.93% <ø> (ø)
unittests 17.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13795

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13797

@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13799

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 13810

@weizhouapache weizhouapache changed the title Switch BouncyCastle dependencies to jdk18on for improved security and… Switch BouncyCastle dependencies to jdk18on for improved security Jun 17, 2025
@weizhouapache
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13813

@DaanHoogland
Copy link
Contributor

@blueorangutan test matrix

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13545)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13544)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13546)

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13543)

@weizhouapache
Copy link
Member

system vms are not coming up
need some more investigation

@weizhouapache
Copy link
Member

there are some smoke test failures, which mean there might be some regression
@sroopsai @DaanHoogland @sureshanaparti

@weizhouapache weizhouapache self-requested a review June 17, 2025 15:38
@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13549)

@weizhouapache weizhouapache marked this pull request as draft June 17, 2025 17:00
@weizhouapache
Copy link
Member

@sroopsai
I moved this PR to draft, as there are more changes required.

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13556)

@weizhouapache
Copy link
Member

@sroopsai
will you investigate the issues ?

@sroopsai
Copy link
Author

sroopsai commented Jun 18, 2025

@weizhouapache I checked the changes once again. I assume I didn't miss a single dependency switch over. I can investigate, but since I am new to Cloudstack, I need some help to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] switch to jdk18on bouncycastle jars
4 participants