Skip to content

Changes baseurl for downloading kubectl #11040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

daviftorres
Copy link
Contributor

Description

This PR changes the baseurl that composes the link to download kubectl on the Access tab of Kubernetes clusters as reported in #11036.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested with wget and the URL.

How did you try to break this feature and the system with this change?

Copy link

boring-cyborg bot commented Jun 16, 2025

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.60%. Comparing base (f8c4121) to head (aeba8f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #11040   +/-   ##
=========================================
  Coverage     16.60%   16.60%           
  Complexity    13925    13925           
=========================================
  Files          5730     5730           
  Lines        508254   508254           
  Branches      61789    61789           
=========================================
+ Hits          84387    84388    +1     
  Misses       414431   414431           
+ Partials       9436     9435    -1     
Flag Coverage Δ
uitests 3.93% <ø> (ø)
unittests 17.49% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland linked an issue Jun 17, 2025 that may be closed by this pull request
@DaanHoogland
Copy link
Contributor

hey @daviftorres , thanks for the contribution. As far as I can see there is no automation to be tested as it is just instructions in the UI. Do you agree?

@DaanHoogland DaanHoogland added this to the 4.21.0 milestone Jun 17, 2025
@nvazquez
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @daviftorres!

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11040 (QA-JID-648)

@daviftorres
Copy link
Contributor Author

hey @daviftorres , thanks for the contribution. As far as I can see there is no automation to be tested as it is just instructions in the UI. Do you agree?

Correct!

@DaanHoogland DaanHoogland merged commit 4662ffc into apache:main Jun 17, 2025
26 checks passed
Copy link

boring-cyborg bot commented Jun 17, 2025

Awesome work, congrats on your first merged pull request!

@daviftorres daviftorres deleted the Changes-baseurl-for-downloading-kubectl branch June 17, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKS 1.33.1 - URL to download kubectl binary is broken
5 participants