Skip to content

Add check for ldap truststore password #11055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 4.19
Choose a base branch
from

Conversation

Pearl1594
Copy link
Contributor

Description

This PR adds validation for the ldap truststore password before adding the ldap server.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 changed the base branch from main to 4.19 June 18, 2025 16:23
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.28%. Comparing base (0d5a0ea) to head (f44baf6).

❗ There is a different number of reports uploaded between BASE (0d5a0ea) and HEAD (f44baf6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0d5a0ea) HEAD (f44baf6)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               4.19   #11055       +/-   ##
=============================================
- Coverage     15.18%    4.28%   -10.90%     
=============================================
  Files          5416      372     -5044     
  Lines        475890    29743   -446147     
  Branches      58093     5229    -52864     
=============================================
- Hits          72254     1274    -70980     
+ Misses       395550    28324   -367226     
+ Partials       8086      145     -7941     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

private boolean validateTrustStore(String trustStore, String trustStorePassword) {
if (trustStore == null || trustStorePassword == null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my opinion

  • if (trustStore == null), return true
  • otherwise, validate truststore by truststorepassword (even if it is null)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can truststore password be null?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be
I am not sure

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
E Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants