-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add check for ldap truststore password #11055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.19
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11055 +/- ##
=============================================
- Coverage 15.18% 4.28% -10.90%
=============================================
Files 5416 372 -5044
Lines 475890 29743 -446147
Branches 58093 5229 -52864
=============================================
- Hits 72254 1274 -70980
+ Misses 395550 28324 -367226
+ Partials 8086 145 -7941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
} | ||
|
||
private boolean validateTrustStore(String trustStore, String trustStorePassword) { | ||
if (trustStore == null || trustStorePassword == null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my opinion
- if (trustStore == null), return true
- otherwise, validate truststore by truststorepassword (even if it is null)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can truststore password be null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be
I am not sure
...ns/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapContextFactory.java
Show resolved
Hide resolved
|
Description
This PR adds validation for the ldap truststore password before adding the ldap server.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?