StorPool: support for direct download

[slavkap]

Description

Added support to download templates on StorPool directly

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale

• Major
• Minor

How Has This Been Tested?

Manually tested

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (019f2c6) to head (b468ca4).
Report is 562 commits behind head on main.

Files with missing lines	Patch %	Lines
...hypervisor/kvm/storage/StorPoolStorageAdaptor.java	0.00%	127 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #9833      +/-   ##
============================================
- Coverage     15.78%   15.78%   -0.01%     
  Complexity    12564    12564              
============================================
  Files          5627     5627              
  Lines        492250   492374     +124     
  Branches      61405    62914    +1509     
============================================
- Hits          77710    77709       -1     
- Misses       406066   406191     +125     
  Partials       8474     8474              

Flag	Coverage Δ
uitests	4.04% <ø> (ø)
unittests	16.60% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

command can be attach and detach only, right? can use bool instead of string, or for define any enum for operation and use that.

[slavkap]

@sureshanaparti, yes, there is an option for boolean/enum, but this method is used almost everywhere in the StorPool plug-in (agent's part). I don't think this PR is the place for refactoring

[DaanHoogland]

clgtm

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[nvazquez]

Code LGTM

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13626

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13719

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13737

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13513)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53944 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9833-t13513-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File