Revert back to jgit for collecting git status

[dweiss]

Description

Revert native git to jgit for collecting git status.

[dweiss]

I'd like to note that we use native git for other things within the build - assembling a source tgz, fetching repos for hunspell... I can add jgit support for this status fetching but maybe we should just add an expectation that native git is available and simplify the build this way?

One thing less to worry about. Let me know how strong you feel we need this jgit support, Uwe. Not a big problem - I'm just wondering if it's worth it.

[rmuir]

My biggest complaint about jgit is that it doesn't truly match git behavior. But I already set special options (e.g. pull.twohead=recursive) to work around bugs in jgit, so I don't care that strongly either way. From technical perspective, the native git is superior.

[dsmiley]

Why revert back to jgit?

[dweiss]

@uschindler asked for it - simpler to manage on Windows vm boxes, I guess. I think we can make it an option to use native or jgit... but I'd rather simplify than complicate so I'll wait for Uwe to respond if he cares that much (since he already installed git on policeman jenkins).

[uschindler]

Hi,
We can keep it as is, all fine.

The "working copy clean" check was faster and better implemented with jgit, but for normal stuff like checking out/exporting using native git is better.

I think the problems appeared on main branch because due to removing the working copy status groovy code, the jgit dependency was no longer resolved and therefore other parts in the Gradle build system were no longer able to fallback to jgit.

So you can close this.

P.S.: for checking out Jenkins still uses jgit internally. But I had to install native git on the windows VM.

[dweiss]

Thanks, Uwe.

The "working copy clean" check was faster and better implemented with jgit

It's not that bad, really - the format of the git tool's status may be a bit odd but it's ok once you read through the docs [1]. We just parse the output of native git [2]. Should work with all sorts of git extensions, respect local user settings, etc.

[1] https://git-scm.com/docs/git-status#_porcelain_format_version_2
[2] https://github.com/apache/lucene/blob/main/build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/gitinfo/GitInfoValueSource.java#L63-L91