-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make pack
methods public for BigIntegerPoint
and HalfFloatPoint
#14784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
I have just updated the CHANGES.txt adding to 10.2.2, please let me know if this is ok else I can change back to 10.3.0. |
I'm good with the change, but I'd put the change in 10.3 instead of 10.2.2 since it's a new feature rather than a bug fix. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Thanks Adrien, updated the CHANGES.txt moving to 10.3.0. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Just pushed a commit to fix the conflicts. @jpountz a gentle follow up to see if we are ok to merge this change. |
…#14784) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Description
Following this commit 94c76c7 make
pack
methods public forBigIntegerPoint
andHalfFloatPoint
.Please let me know if there’s any restriction in sandbox packages that requires methods to be non-public.
Example (with IntPoint) with public
pack
we can directly use as followsWithout pack
Once this PR is merged we can: