Skip to content

Correct python release scripts for the new location of base version #14798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

dweiss
Copy link
Contributor

@dweiss dweiss commented Jun 16, 2025

#14786

Description

Copy link

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@dweiss dweiss marked this pull request as draft June 16, 2025 21:02
@rmuir
Copy link
Member

rmuir commented Jun 16, 2025

Try a make reformat. Not sure what editor you use, but eg for vscode if you can install ruff and basedpyright extensions, and enable format-on-save and organize-imports-on-save too, you will pretty much never need to deal with make. Lmk, I can try to document or add eg vscode settings file or whatever helps.

@dweiss
Copy link
Contributor Author

dweiss commented Jun 16, 2025

Thanks. I think I'll go back to the regexp-scan instead of using the javaproperties module. I don't think we import the requirements in github workflow that runs the tests... Will return to it tomorrow, I'm done for today.

@rmuir
Copy link
Member

rmuir commented Jun 16, 2025

For now you can try make autofix which is like make reformat but will also (safely) fix any linter issues it can too.

@rmuir
Copy link
Member

rmuir commented Jun 16, 2025

#14799 to make the messaging better when make lint fails.

@dweiss dweiss marked this pull request as ready for review June 17, 2025 09:30
@dweiss dweiss merged commit 35f9ca2 into apache:main Jun 17, 2025
8 checks passed
@dweiss dweiss deleted the 14786-correct-python-release-scripts branch June 17, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants