Utilize docIdRunEnd on ReqExclBulkScorer
#14806
Conversation
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| if (exclTwoPhase == null) { | ||
| // from upTo to docIdRunEnd() are excluded, so we scored up to docIdRunEnd() | ||
| upTo = exclApproximation.docIDRunEnd(); | ||
| } else if (exclTwoPhase.matches()) { |
There was a problem hiding this comment.
Is upTo = Math.max(upTo + 1, exclTwoPhase.docIdRunEnd()) correct here?
There was a problem hiding this comment.
I think it's correct here, and I run lucene test locally, everything looks fine. What I'm concerned here is that only DocValuesRangeIterator implement it's own docIdRunEnd method for now, I'm not sure whether adding this will hurt the performance or not
| if (exclTwoPhase == null || exclTwoPhase.matches()) { | ||
| if (exclTwoPhase == null) { | ||
| // from upTo to docIdRunEnd() are excluded, so we scored up to docIdRunEnd() | ||
| upTo = exclApproximation.docIDRunEnd(); |
There was a problem hiding this comment.
Do we need to check exclApproximation.docID() != DocIdSetIterator#NO_MORE_DOCS?
There was a problem hiding this comment.
If I understand correctly, exclApproximation.docID() should equals exclDoc, which is equal to upTo (under the if clause ), and upTo is less than max, so exclApproximation.docID() should never be DocIdSetIterator#NO_MORE_DOCS?
There was a problem hiding this comment.
Oh yes, You are right. Thanks for explanation!
Description
This PR propose to utilize
docIdRunEndonReqExclBulkScorer, so we can jump faster onMUST_NOTclause