Skip to content

Add isEmpty in PriorityQueue. #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vsop-479
Copy link
Contributor

Description

Copy link

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@stefanvodita stefanvodita added the skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. label Jun 19, 2025
Copy link
Contributor

@stefanvodita stefanvodita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we expand public API, can we have a good justification, e.g. use this somewhere in Lucene or explain how you would like to use it in your application?

@@ -342,4 +342,13 @@ public T next() {
}
};
}

/**
* Returns {@code true} if this list contains no elements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just keep the other line in the comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:core/other skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants