Rename polaris-quarkus-* projects as polaris-* and renaming quarkus folder as runtime #1695

jbonofre · 2025-05-28T09:17:16Z

Quarkus is an implementation "detail", the end users should not be "bothered" by this.
I propose here to use "abstract" name in tasks (using direction polaris-* instead of polaris-quarkus-*) and rename quarkus folder as runtime.

If later we want/need to replace the runtime framework, it won't change the structure.

dimas-b

This renaming proposal sounds good to me 👍

gradle/projects.main.properties

flyrain · 2025-05-28T18:52:46Z

+1 to renaming. Thanks for doing this. Just a heads-up: sweeping changes like this hit many surfaces, including “getting started” pages and instructions, that CI never sees. We’ve been burned before, PR #1532 broke plenty of things without breaking a single test in CI. So let’s do extra manual verification before we merge.

gradle/projects.main.properties

dimas-b

This renaming LGTM 👍

jbonofre · 2025-06-12T15:58:46Z

FYI, any change on main means a rebase/conflict on this PR. If we don't have consensus here, let's do it later.

jbonofre · 2025-06-16T17:10:28Z

I did the rebase.

@flyrain can you please take a look ?

I would like to merge this if it works for you. Thanks for the review @adutra @dimas-b @snazy !

dimas-b · 2025-06-16T18:48:10Z

@jbonofre : Python CI failed with Cannot locate tasks that match ':polaris-quarkus-server:assemble' as project 'polaris-quarkus-server' not found in root project 'polaris'.

flyrain · 2025-06-17T01:33:29Z

Hi @jbonofre — thanks for driving this. A few tidy-up ideas while we’re here:

Rename polaris-runtime-distribution → polaris-distribution (keeps it aligned with polaris-admin and polaris-server). And we might move it out of directory runtime as it is just a packaging module.
Rename polaris-runtime-test-commons → polaris-runtime-test-common for singular/plural consistency.
Optional follow-up: merge polaris-server into polaris-service to simplify the module layout (not a blocker for this PR).

Thoughts?

dimas-b · 2025-06-17T01:46:34Z

Optional follow-up: merge polaris-server into polaris-service to simplify the module layout (not a blocker for this PR).

I'm strongly -1 on this. I'm pretty sure this is going to complicate the reuse of polaris-service code in downstream projects.

jbonofre · 2025-06-17T05:37:48Z

@jbonofre : Python CI failed with Cannot locate tasks that match ':polaris-quarkus-server:assemble' as project 'polaris-quarkus-server' not found in root project 'polaris'.

I'm fixing, that's due to rebase.

jbonofre · 2025-06-17T05:42:19Z

I updated the PR with:

Fix python CI
Rename polaris-runtime-distrtibution to polaris-distribution
Rename polaris-runtime-test-commons to polaris-runtime-test-common

@flyrain @dimas-b mind to do a new pass ? Thanks !

adutra · 2025-06-17T08:08:12Z

Optional follow-up: merge polaris-server into polaris-service to simplify the module layout (not a blocker for this PR).

I'm strongly -1 on this. I'm pretty sure this is going to complicate the reuse of polaris-service code in downstream projects.

Agreed. However, in a follow-up PR, imho we could merge polaris-service-common into polaris-runtime-service.

jbonofre · 2025-06-17T08:13:54Z

Optional follow-up: merge polaris-server into polaris-service to simplify the module layout (not a blocker for this PR).

I'm strongly -1 on this. I'm pretty sure this is going to complicate the reuse of polaris-service code in downstream projects.

Agreed. However, in a follow-up PR, imho we could merge polaris-service-common into polaris-runtime-service.

I agree to have a follow-up PR and happy to do that. I think the most important for 1.0 release is about the Maven coordinates and names "visible" to users.

flyrain

LGTM. Thanks @jbonofre !

flyrain · 2025-06-17T15:57:57Z

Minor: we might change the dir test-commons to test-common to be consistent

jbonofre · 2025-06-17T15:59:43Z

@flyrain sorry I missed your comment, let me do another PR about test-commons rename.

adutra · 2025-06-19T14:15:12Z

Optional follow-up: merge polaris-server into polaris-service to simplify the module layout (not a blocker for this PR).

I'm strongly -1 on this. I'm pretty sure this is going to complicate the reuse of polaris-service code in downstream projects.

Agreed. However, in a follow-up PR, imho we could merge polaris-service-common into polaris-runtime-service.

I agree to have a follow-up PR and happy to do that. I think the most important for 1.0 release is about the Maven coordinates and names "visible" to users.

@jbonofre do you plan to work on this? Otherwise I can look into it.

While it's not so critical, it's still a user-facing change since the polaris-service-common artifact would disappear.

# This is the 1st commit message: apache#772 fixed integration tests and synched with main Mypy did a new release 1.16.1 and it cause our CI to fail for about 20 minutes due to missing wheel (upload not completed) ``` | Unable to find installation candidates for mypy (1.16.1) | | This is likely not a Poetry issue. | | - 14 candidate(s) were identified for the package | - 14 wheel(s) were skipped as your project's environment does not support the identified abi tags | | Solutions: | Make sure the lockfile is up-to-date. You can try one of the following; | | 1. Regenerate lockfile: poetry lock --no-cache --regenerate | 2. Update package : poetry update --no-cache mypy | | If neither works, please first check to verify that the mypy has published wheels available from your configured source that are compatible with your environment- ie. operating system, architecture (x86_64, arm64 etc.), python interpreter. | ``` This PR temporarily restrict the mypy version to avoid the similar issue. We may consider bring poetry.lock back to git tracking so we won't automatically update test dependencies all the time # This is the commit message apache#48: Remove `.github/CODEOWNERS` (apache#1902) As per this [dev-ML discussion](https://lists.apache.org/thread/jjr5w3hslk755yvxy8b3z45c7094cxdn) # This is the commit message apache#49: Rename quarkus as runtime (apache#1695) # This is the commit message apache#50: parent 3185adf author Mend Renovate <bot@renovateapp.com> 1749165686 +0200 committer Rizzo Cascio, Fabio <fabio.rizzocascio@jpmorgan.com> 1749646499 +0100 # This is a combination of 2 commits. # This is the 1st commit message: Mutable objects used for immutable values apache#772: resolved conflicts # This is the commit message apache#51: Mutable objects used for immutable values apache#772: fixed integration tests # This is the commit message apache#52: parent 3185adf author Mend Renovate <bot@renovateapp.com> 1749165686 +0200 committer Rizzo Cascio, Fabio <fabio.rizzocascio@jpmorgan.com> 1749646499 +0100 # This is a combination of 2 commits. # This is the 1st commit message: Mutable objects used for immutable values apache#772: resolved conflicts Mutable objects used for immutable values apache#772: added final to base and core fields Mutable objects used for immutable values apache#772: fixed tests

github-project-automation bot added this to Basic Kanban Board May 28, 2025

jbonofre requested review from adutra, ashvina, dennishuo, dimas-b, eric-maynard, jackye1995, vvcephei, collado-mike and snazy as code owners May 28, 2025 09:17

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board May 28, 2025

jbonofre requested review from RussellSpitzer, takidau, MonkeyCanCode, flyrain, ebyhr, ajantha-bhat, HonahX, singhpk234 and pingtimeout as code owners May 28, 2025 09:17

dimas-b reviewed May 28, 2025

View reviewed changes

gradle/projects.main.properties Outdated Show resolved Hide resolved

jbonofre added the 1.0-blocker label Jun 6, 2025

jbonofre force-pushed the rename-quarkus-to-runtime branch from 6169365 to 8772513 Compare June 10, 2025 15:47

jbonofre requested a review from dimas-b June 10, 2025 15:48

jbonofre force-pushed the rename-quarkus-to-runtime branch from 8772513 to f5db872 Compare June 10, 2025 15:50

dimas-b reviewed Jun 10, 2025

View reviewed changes

gradle/projects.main.properties Show resolved Hide resolved

dimas-b previously approved these changes Jun 10, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 10, 2025

jbonofre dismissed stale reviews from dimas-b and adutra via efd34d5 June 16, 2025 17:09

jbonofre force-pushed the rename-quarkus-to-runtime branch from 515a493 to efd34d5 Compare June 16, 2025 17:09

jbonofre added the 1.0-blocker label Jun 16, 2025

dimas-b previously approved these changes Jun 16, 2025

View reviewed changes

Rename quarkus as runtime

5311143

jbonofre dismissed dimas-b’s stale review via 5311143 June 17, 2025 05:41

jbonofre force-pushed the rename-quarkus-to-runtime branch from efd34d5 to 5311143 Compare June 17, 2025 05:41

jbonofre requested review from dimas-b and adutra June 17, 2025 05:42

adutra approved these changes Jun 17, 2025

View reviewed changes

flyrain approved these changes Jun 17, 2025

View reviewed changes

jbonofre merged commit ab228af into apache:main Jun 17, 2025
9 checks passed

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jun 17, 2025

jbonofre mentioned this pull request Jun 17, 2025

Rename runtime/test-commons to runtime/test-common (for consistency with module name) #1906

Merged

flyrain pushed a commit that referenced this pull request Jun 18, 2025

Rename quarkus as runtime (#1695)

6fd2b65

ebyhr mentioned this pull request Jul 3, 2025

Fix build command in Polaris trinodb/docker-images#247

Merged

Rename polaris-quarkus-* projects as polaris-* and renaming quarkus folder as runtime #1695

Rename polaris-quarkus-* projects as polaris-* and renaming quarkus folder as runtime #1695

Uh oh!

Conversation

jbonofre commented May 28, 2025

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

flyrain commented May 28, 2025

Uh oh!

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

jbonofre commented Jun 12, 2025

Uh oh!

jbonofre commented Jun 16, 2025

Uh oh!

dimas-b commented Jun 16, 2025

Uh oh!

flyrain commented Jun 17, 2025

Uh oh!

dimas-b commented Jun 17, 2025

Uh oh!

jbonofre commented Jun 17, 2025

Uh oh!

jbonofre commented Jun 17, 2025

Uh oh!

adutra commented Jun 17, 2025

Uh oh!

jbonofre commented Jun 17, 2025

Uh oh!

flyrain left a comment

Choose a reason for hiding this comment

Uh oh!

flyrain commented Jun 17, 2025

Uh oh!

Uh oh!

jbonofre commented Jun 17, 2025

Uh oh!

adutra commented Jun 19, 2025

Uh oh!

Uh oh!