-
Notifications
You must be signed in to change notification settings - Fork 287
Bump version in version.txt [1.0] #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not use the 1.0.x branch. It's not the branch that's documented in the release guide on the web site.
@snazy I understood that the branch was going to be renamed, are you suggesting that we instead cut a new branch from the tip of main? |
version.txt
Outdated
@@ -1 +1 @@ | |||
0.11.0-beta-incubating-SNAPSHOT | |||
1.0.0-incubating-SNAPSHOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wasn't clear in my previous comment.
On release branch, it's not a SNAPSHOT, it's a release, so 1.0.0-incubating
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, nope. On a tag it's a release version - but not in a branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Otherwise you get a non-reproducible build)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the other branches it looks like it should have no SNAPSHOT but let me know if this does need to change back
Yep (probably quicker than tweaking an existing PR). |
@snazy I'll leave the question of rename vs. new cut to the release manager; my (incorrect?) assumption was that once we've picked a commit to release from we'd prefer not to change that lightly. If we end up closing the target branch here we can cherry pick this onto the new branch 👍 |
Yea - cherry-picking on the new branch is fine for me. I'd be very careful with removing the BTW, if you're interested: Some technical background on semi-automatic releases is here. There are quite some annoying things for releases that can go wrong - most annoying is "concurrent merges/commits" that do happen in real life. |
Just changed the target to the new branch |
I do not think the scope for 1.0 is completely set per dev email thread: https://lists.apache.org/thread/g1m3nj9g7jnrvkd9ogq6h3v4cmll5lwo Let's hold version updates until we have consensus there. |
@dimas-b I have only been loosely following that thread, but it looks like we may be all set now? |
The question of re-branching from Re: scope, let's use that dev ML thread for any follow-up items. |
With the 1.0 release branch being cut, we should bump this to reflect the current state of main