-
Notifications
You must be signed in to change notification settings - Fork 22
Add AwsBatchLogProcessor and OtlpAwsLogExporter Logs Pipeline #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
reviewed
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran out of time, did not review tests or _estimate_log_size
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Show resolved
Hide resolved
...etry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/otlp_aws_logs_exporter.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
thpierce
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will not be able to review tests, simply no bandwidth left.
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Show resolved
Hide resolved
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Outdated
Show resolved
Hide resolved
...etry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/otlp_aws_logs_exporter.py
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...etry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/otlp_aws_logs_exporter.py
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...entelemetry-distro/tests/amazon/opentelemetry/distro/test_aws_opentelementry_configurator.py
Outdated
Show resolved
Hide resolved
...y-distro/tests/amazon/opentelemetry/distro/exporter/otlp/aws/common/test_aws_auth_session.py
Outdated
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 30, 2025
aws-opentelemetry-distro/src/amazon/opentelemetry/distro/aws_opentelemetry_configurator.py
Show resolved
Hide resolved
mxiamxia
reviewed
Jun 30, 2025
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
srprash
reviewed
Jul 1, 2025
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
...etry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/otlp_aws_logs_exporter.py
Show resolved
Hide resolved
thpierce
reviewed
Jul 2, 2025
...tro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/aws_batch_log_record_processor.py
Outdated
Show resolved
Hide resolved
srprash
reviewed
Jul 2, 2025
...etry-distro/src/amazon/opentelemetry/distro/exporter/otlp/aws/logs/otlp_aws_logs_exporter.py
Outdated
Show resolved
Hide resolved
srprash
approved these changes
Jul 2, 2025
liustve
added a commit
to aws-observability/aws-otel-js-instrumentation
that referenced
this pull request
Jul 3, 2025
…bjects (#209) *Description of changes:* JS version of - aws-observability/aws-otel-python-instrumentation#402 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support CW Logs implementation for handling LLO and adhering to their new limits in ADOT, they specifically indicated that if the log is an LLO then we would export immediately:
Furthermore they need a new header for the log object that contains all of the paths to the String leaf nodes in the log body represented in
JSON protobuf
format. Below is a representation of the consolidated Gen AI event log schema in JSON protobuf format.Description of changes:
Adds
AwsBatchLogRecordProcessor
a backwards compatible custom logs BatchProcessor which has the following invariants:exported batch is ever > 1 MB
then the batch size is always length 1Added support for estimating the size of a log record based on its body and attributes. However, because logs are represented as a self-referential data-type, the log record can potentially be very nested and complex. In order to lower the impact on performance when calculating the size of a log, a depth limit is added to how deep the log will be searched.
OTLPAwsLogExporter
: Adds a new behavior for Retry delay based on server-side response of Retry-After header.Injects the LLO header flag if the size of the exported data > 1 MB.Customize the auto instrumentation to use the new
AwsBatchLogRecordProcessor
Testing
AwsBatchLogRecordProcessor
to support the new LLO handling logicOtlpAwsLogExporter
to validate the new Retry and LLO header logicBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.