This repository was archived by the owner on Jun 16, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 251
Enhance httpx tracing #1186
Open
macieyng
wants to merge
6
commits into
census-instrumentation:master
Choose a base branch
from
macieyng:enhance-httpx-tracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Enhance httpx tracing #1186
macieyng
wants to merge
6
commits into
census-instrumentation:master
from
macieyng:enhance-httpx-tracing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@macieyng update the changelog |
Thanks @lzchen for running the pipeline. I will fix it tomorrow. |
@lzchen ready for running the pipeline 🚀 |
@lzchen can you run the pipeline? Thanks! 🙏 |
That's not something that I touched and on my machine it fails even earlier, but that's because I'm running it locally on mac. @lzchen can I get your support with sorting this out? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In httpx
Advanced Usage
docs there is a chapterRequest Instances
where they show alternative way of sending requests, where you can use once initialized client to send various of different requests to the same host.Current implementation of tracing doesn't cover that use case, because calling structure is different while function
Client.send
is actually what is common and it returnsResponse
object.In a nutshell:
so when I have something like this:
It's not traced.
The solution in this PR will cover both use cases - the standard one (requests-like) and the advanced usage.