Skip to content

GitHub workflow #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

GitHub workflow #4

wants to merge 4 commits into from

Conversation

jposada202020
Copy link

Adding the Github workflow directory

@FoamyGuy
Copy link
Collaborator

I think we may want to see if it's possible to use the newer actions repo in build.yml instead of having everything directly in build here. This one is linked that way: https://github.com/adafruit/Adafruit_CircuitPython_Display_Text/blob/main/.github/workflows/build.yml

I'm not sure if there are any differences that will be needed due to circuitpython org instead of adafruit org, but ideally we want to re-use as much as we can.

having it in a seperate centralized location makes it easier to update the actions across all repos if/when the time comes.

@jposada202020
Copy link
Author

@FoamyGuy Please take a look a #7 This solves the CI action, however it will fail, as the library needs some corrections to pass the test completely. So I propose the following:
We integrate the build.yml either manually or via PR even if the CI fails and then we could integrate PR #6 that will fix the library infrastructure problems. Let me know. Thanks :). Also I will close this one as #5 has the same intention and is cleaner. Thanks

@jposada202020 jposada202020 mentioned this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants