Skip to content

Remove Node.js 18.x support #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 7, 2025
Merged

Remove Node.js 18.x support #299

merged 4 commits into from
Jul 7, 2025

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 9, 2025

🤔 What's changed?

Remove Node.js 18 support by removing the testing.

⚡️ What's your motivation?

Node.js 18 is now end of life per https://nodejs.org/en/about/previous-releases. Dropping it enables us to adopt new platform features and get rid of debt.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@davidjgoss davidjgoss marked this pull request as ready for review May 9, 2025 08:10
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpkorstanje mpkorstanje merged commit 4d38486 into main Jul 7, 2025
37 checks passed
@mpkorstanje mpkorstanje deleted the drop-node-18 branch July 7, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants