Skip to content

Simplied preview environment header check #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025

Conversation

adamzap
Copy link
Member

@adamzap adamzap commented May 13, 2025

As a follow-up to discussion in #2052, this patch uses a template-based check to show the preview banner instead of a context processor.

This will need to be tested on the preview environment.

As a follow-up to discussion in django#2052, this patch uses a template-based
check to show the preview banner instead of a context processor.
Copy link
Member

@pauloxnet pauloxnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pauloxnet pauloxnet merged commit 57c46b3 into django:main May 19, 2025
4 checks passed
@adamzap adamzap deleted the simplify-preview-header branch May 20, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants