Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 3, 2025

Removes eng/helixpublish.proj. It looks like the repo doesn't use Helix to run tests?

Microsoft Reviewers: Open in CodeFlow

@Youssef1313 Youssef1313 marked this pull request as ready for review June 3, 2025 07:59
Copilot AI review requested due to automatic review settings June 3, 2025 07:59
@Youssef1313 Youssef1313 requested a review from a team as a code owner June 3, 2025 07:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused eng/helixpublish.proj file that is no longer necessary since the repo does not use Helix for test execution.

  • Removed eng/helixpublish.proj since Helix testing is not in use
Comments suppressed due to low confidence (1)

eng/helixpublish.proj:1

  • Ensure that any documentation or build scripts referring to helixpublish.proj are updated to reflect its removal.
Entire file removal

@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label Jun 3, 2025
@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.98859%. Comparing base (1642c81) to head (82b3892).
Report is 1 commits behind head on main.

Additional details and impacted files
@@                Coverage Diff                @@
##               main     #10907         +/-   ##
=================================================
+ Coverage   2.98814%   2.98859%   +0.00044%     
=================================================
  Files          3319       3319                 
  Lines        664895     664895                 
  Branches      74675      74675                 
=================================================
+ Hits          19868      19871          +3     
+ Misses       644846     644844          -2     
+ Partials        181        180          -1     
Flag Coverage Δ
Debug 2.98859% <ø> (+0.00044%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313
Copy link
Member Author

@dipeshmsft Can I have a review here please? Thanks!

@dipeshmsft
Copy link
Member

@Youssef1313, done with the review

@dipeshmsft dipeshmsft merged commit eef8323 into main Jul 20, 2025
8 checks passed
@dipeshmsft dipeshmsft deleted the dev/ygerges/helixpublish branch July 20, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR metadata: Label to tag PRs, to facilitate with triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants