Skip to content

Avoid HandleLimitFS in LookupJoinTypesIT #129437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jun 13, 2025

In this test, we create a hundred indices for different combinations of data types. The number of file descriptors used exceeds the limit of HandleLimitFS; therefore, we avoid using it in this test.

Relates #126150
Closes #129344

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v9.0.3 v8.19.0 auto-backport Automatically create backport pull requests when merged labels Jun 13, 2025
@dnhatn dnhatn marked this pull request as ready for review June 13, 2025 18:46
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 13, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn dnhatn requested review from nik9000 and removed request for alex-spies June 13, 2025 18:47
Copy link
Contributor

@alex-spies alex-spies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Nhat!

@alex-spies
Copy link
Contributor

alex-spies commented Jun 16, 2025

@dnhatn , I'm in the process of refactoring this test in #129355. To avoid an annoying backport dance, I suggest that I go and include your fix right away.

@alex-spies
Copy link
Contributor

Inlcuded in the other PR in e86539b

}
indexRandom(true, indexRequests);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

If we were making more than one value per index this would speed things up a ton. As is it's probably pretty small, but still.

@dnhatn
Copy link
Member Author

dnhatn commented Jun 16, 2025

Thanks friends!

@dnhatn dnhatn merged commit ff76c50 into elastic:main Jun 16, 2025
18 checks passed
@dnhatn dnhatn deleted the fix-file-descriptor-test branch June 16, 2025 15:18
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jun 16, 2025
In this test, we create a hundred indices for different combinations of 
data types. The number of file descriptors used exceeds the limit of
HandleLimitFS; therefore, we avoid using it in this test.

Relates elastic#126150
Closes elastic#129344
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19
9.0

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jun 16, 2025
In this test, we create a hundred indices for different combinations of 
data types. The number of file descriptors used exceeds the limit of
HandleLimitFS; therefore, we avoid using it in this test.

Relates elastic#126150
Closes elastic#129344
elasticsearchmachine pushed a commit that referenced this pull request Jun 16, 2025
In this test, we create a hundred indices for different combinations of 
data types. The number of file descriptors used exceeds the limit of
HandleLimitFS; therefore, we avoid using it in this test.

Relates #126150
Closes #129344
elasticsearchmachine pushed a commit that referenced this pull request Jun 16, 2025
In this test, we create a hundred indices for different combinations of 
data types. The number of file descriptors used exceeds the limit of
HandleLimitFS; therefore, we avoid using it in this test.

Relates #126150
Closes #129344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.19.0 v9.0.3 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] LookupJoinTypesIT testLookupJoinOthers failing
4 participants