✨ Handle case-insensitive functions

Author: homersimpsons

bin/run-tests.sh

@@ -37,13 +37,15 @@ for test_dir in tests/*; do
         diff "${representation_file_path}" "${expected_representation_file_path}"
 
         if [ $? -ne 0 ]; then
+            echo "FAILED"
             exit_code=1
         fi
 
         echo "${test_dir_name}: comparing mapping.json to expected_mapping.json"
         diff "${mapping_file_path}" "${expected_mapping_file_path}"
 
         if [ $? -ne 0 ]; then
+            echo "FAILED"
             exit_code=1
         fi
     fi

phpunit-tests/FunctionMappingTest.php

@@ -48,7 +48,7 @@ function helloWorldB()
             }
             CODE;
 
-        $this->assertSameRepresentationWithMapping($codeA, $codeB, '{"fn0":"helloWorldA"}', '{"fn0":"helloWorldB"}');
+        $this->assertSameRepresentationWithMapping($codeA, $codeB, '{"fn0":"helloworlda"}', '{"fn0":"helloworldb"}');
     }
 
     public function testDoesNotRenameCoreFunctions(): void
@@ -64,4 +64,40 @@ public function testDoesNotRenameCoreFunctions(): void
             '{}',
         );
     }
+
+    public function testCaseInsensitiveFunctions(): void
+    {
+        $code = <<<'CODE'
+            <?php
+            function A() {}
+            a();
+            CODE;
+
+        $this->assertRepresentation(
+            $code,
+            <<<'CODE'
+            function fn0()
+            {
+            }
+            fn0();
+            CODE,
+            '{"fn0":"a"}',
+        );
+    }
+
+    public function testCaseInsensitiveNativeFunctions(): void
+    {
+        $code = <<<'CODE'
+            <?php
+            FunCtioN_ExiStS();
+            CODE;
+
+        $this->assertRepresentation(
+            $code,
+            <<<'CODE'
+            function_exists();
+            CODE,
+            '{}',
+        );
+    }
 }

phpunit-tests/HelloWorldTest.php

@@ -29,6 +29,6 @@ function fn0()
         }
         EOF
         , $result);
-        $this->assertEquals('{"fn0":"helloWorld"}', $mapping->toJson());
+        $this->assertEquals('{"fn0":"helloworld"}', $mapping->toJson());
     }
 }

phpunit-tests/StripCommentTest.php

@@ -29,7 +29,7 @@ function fn0()
             return "Hello World!";
         }
         EOF,
-            '{"fn0":"helloWorld"}',
+            '{"fn0":"helloworld"}',
         );
     }
 }

phpunit-tests/VariableMappingTest.php

@@ -31,8 +31,8 @@ function helloWorld()
         $this->assertSameRepresentationWithMapping(
             $codeA,
             $codeB,
-            '{"fn0":"helloWorld","v0":"a"}',
-            '{"fn0":"helloWorld","v0":"b"}',
+            '{"fn0":"helloworld","v0":"a"}',
+            '{"fn0":"helloworld","v0":"b"}',
         );
     }
 }

src/Mapping.php

@@ -11,6 +11,7 @@
 use function get_defined_functions;
 use function json_encode;
 use function ksort;
+use function mb_strtolower;
 
 use const JSON_FORCE_OBJECT;
 use const JSON_THROW_ON_ERROR;
@@ -51,6 +52,8 @@ public function toJson(): string
 
     public function addFunction(string $name): string
     {
+        // TRANSFORM: Function names are case-insensitive in PHP
+        $name = mb_strtolower($name);
         // Do not rename built-in functions, functions_exists() includes user-defined functions
         if (array_key_exists($name, $this->internalFunctions)) {
             return $name;