Limitation in mapping.json: case insensitivity

[homersimpsons]

In PHP some tokens are case-insensitive, namely:

• Functions names: https://www.php.net/manual/en/functions.user-defined.php

  Note: Function names are case-insensitive for the ASCII characters A to Z, though it is usually good form to call functions as they appear in their declaration.

• class names
• methods (functions in classes)

The current mapping.json design allows to map a string from the "canonical" representation.txt to a single value from the original source.

With PHP's case insensitivity this is not enough, in fact given the following code:

<?php
function hElLoWoRlD() {}
HeLlOwOrLd();

our reprensentation.txt file will look like:

function f0() {}
f0();

and our mapping.json file will look like:

{"fn0":"helloworld"}

What can we do about those cases @ErikSchierboom ?

We could upgrade the mapping.json structure to allow something like:

{"fn0":["hElLoWoRlD","HeLlOwOrLd"]}

[github-actions]

Hello. Thanks for opening an issue on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

---

Note: If this issue has been pre-approved, please link back to this issue on the forum thread and a maintainer or staff member will reopen it.

[ErikSchierboom]

{"fn0":"helloworld"}

Why does it look like this and not like

{"fn0":"hElLoWoRlD"}

[homersimpsons]

Because I normalize the name, but even if I represent it like:

{"fn0":"hElLoWoRlD"}

There still is the issue that "HeLlOwOrLd" is not part of the mapping.json while it still is mapped.

[ErikSchierboom]

Is that because when you analyze the code you no longer have access to the original text?

[homersimpsons]

Is that because when you analyze the code you no longer have access to the original text?

No, I still have the original text, in fact I do those transformations here:

php-representer/src/Mapping.php

Line 89 in 9b99149

$name = mb_strtolower($name);

php-representer/src/Mapping.php

Line 121 in 9b99149

$name = mb_strtolower($name);

php-representer/src/Mapping.php

Line 133 in 9b99149

$name = mb_strtolower($name);

But as I said in the original issue, PHP is case insensitive on those tokens, so even if I keep HeLlOwOrLd there will still be an issue with hElLoWoRlD which on PHP side are considered the same.

Maybe this is acceptable, I do not know what is exactly the purpose of the mapping.json file. If it is to generate feedback and it just expands the mapping into the text this might be sufficient.

[ErikSchierboom]

If it is to generate feedback and it just expands the mapping into the text this might be sufficient.

It is exactly this.

[homersimpsons]

If it is to generate feedback and it just expands the mapping into the text this might be sufficient.

It is exactly this.

Okay perfect, I will then just track the "most common" mapping value so it should feel consistent enough for the user.

Alternatively I could also write the mapping as {"fn0":"hElLoWoRlD (HeLlOwOrLd)"} do you think that would make sense ?

[ErikSchierboom]

Nah, I would just use the "most common" one