Drop jquery #62
Merged
Drop jquery #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mainly used jQuery because fancybox depended on it. But both our version of fancybox and our version of jquery where severely outdated. Current versions of fancybox are only available under a commercial license, so we switch to an open source alternative. Baguettebox was chosen because it's small, actively maintained, has no dependencies and offers all the features we used in fancybox. Signed-off-by: Matthias Aßhauer <mha1993@live.de>
html5shiv.js and response.js where originally added to support internet explorer versions prior to version 9. We don't support internet explorer anymore, but didn't drop these scripts yet. Signed-off-by: Matthias Aßhauer <mha1993@live.de>
|
We still need jQuery for replace Download button After you drop it $('a.button:contains("Download")')[0]
Uncaught SyntaxError: Failed to execute '$' on 'CommandLineAPI': 'a.button:contains("Download")' is not a valid selector.
at <anonymous>:1:1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview available at https://rimrul.github.io/git-for-windows.github.io/
Fixes git-for-windows/git#5605