Improve JSON validation in start-proxy
action
#2956
Draft
+126
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes three changes related to the
start-proxy
action:null
values as meaningful.password
is actually atoken
, which can lead to confusion when inspecting the logs and seeing thattoken
isundefined
even when it is expected to be defined. We believe thatusername
is alwaysundefined
in that case, so we can use that as an indicator to treat thepassword
as thetoken
instead.Merge / deployment checklist