Remove failing test for FIO38-C #255

mbaluda · 2023-03-15T17:41:18Z

Description

Removes a test for FIO38-C that does compile properly with qcc

Change request type

Release or process automation (GitHub workflows, internal scripts)
Internal documentation
External documentation
Query files (.ql, .qll, .qls or unit tests)
External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

No rules added
Queries have been added for the following rules:
- rule number here
Queries have been modified for the following rules:
- rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

The structure or layout of the release artifacts.
The evaluation performance (memory, execution time) of an existing query.
The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

Yes
No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

Reviewer

Have all the relevant rule package description files been checked in?
Have you verified that the metadata properties of each new query is set appropriately?
Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
Are the alert messages properly formatted and consistent with the style guide?
Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Does the query have an appropriate level of in-query comments/documentation?
Have you considered/identified possible edge cases?
Does the query not reinvent features in the standard library?
Can the query be simplified further (not golfed!)

github-actions · 2023-03-15T17:41:36Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-15T17:42:39Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T17:42:39Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T19:28:20Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T20:15:53Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-15T21:48:27Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-15T21:49:28Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T21:50:03Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


SUITE                : CERT-C
PACKAGE              : IO2
QUERY                : DoNotCopyAFileObject
RULE                 : FIO38-C
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
TEST_PASS            : True
TEST_DIFFERENCE      :

jsinglet · 2023-03-15T21:51:18Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T21:51:19Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-15T21:51:53Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_PASS            : True
PACKAGE              : IO2
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
QUERY                : DoNotCopyAFileObject
COMPILE_ERROR_OUTPUT : 
RULE                 : FIO38-C
SUITE                : CERT-C

jsinglet · 2023-03-15T21:53:01Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
TEST_PASS            : True
COMPILE_PASS         : True
COMPILE_ERROR_OUTPUT : 
RULE                 : FIO38-C
QUERY                : DoNotCopyAFileObject
SUITE                : CERT-C
PACKAGE              : IO2

jsinglet · 2023-03-15T21:53:14Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

c/cert/test/rules/FIO38-C/test.c.qcc

github-actions · 2023-03-20T11:34:10Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-03-20T11:34:37Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-20T11:35:59Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : FIO38-C
COMPILE_PASS         : True
TEST_DIFFERENCE      : --- expected
                       +++ actual
                       @@ -1,5 +1,4 @@
                        | test.c:4:20:4:26 | * ... | A FILE object is being copied. |
                        | test.c:11:21:11:30 | * ... | A FILE object is being copied. |
                       -| test.c:17:21:17:31 | * ... | A FILE object is being copied. |
                       -| test.c:23:15:23:21 | * ... | A FILE object is being copied. |
                       -| test.c:36:19:36:28 | * ... | A FILE object is being copied. |
                       +| test.c:17:15:17:21 | * ... | A FILE object is being copied. |
                       +| test.c:30:19:30:28 | * ... | A FILE object is being copied. |
                       [1/1 comp 31.3s eval 1.2s] FAILED(RESULT) /__w/codeql-coding-standards-release-engineering/codeql-coding-standards-release-engineering/codeql-coding-standards/c/cert/test/rules/FIO38-C/DoNotCopyAFileObject.qlref
                       
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : False
SUITE                : CERT-C
PACKAGE              : IO2
QUERY                : DoNotCopyAFileObject

jsinglet · 2023-03-20T11:36:37Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR won't happen because it is outside of license window!

jsinglet · 2023-03-20T14:18:12Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T14:18:33Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


RULE                 : FIO38-C
SUITE                : CERT-C
COMPILE_PASS         : True
TEST_DIFFERENCE      : 
COMPILE_ERROR_OUTPUT : 
QUERY                : DoNotCopyAFileObject
TEST_PASS            : True
PACKAGE              : IO2

jsinglet · 2023-03-20T14:18:34Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
SUITE                : CERT-C
RULE                 : FIO38-C
COMPILE_PASS         : True
QUERY                : DoNotCopyAFileObject
PACKAGE              : IO2
TEST_DIFFERENCE      : 
TEST_PASS            : True

jsinglet · 2023-03-20T14:19:27Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T14:21:18Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
PACKAGE              : IO2
QUERY                : DoNotCopyAFileObject
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
RULE                 : FIO38-C
TEST_DIFFERENCE      : 
SUITE                : CERT-C

jsinglet · 2023-03-20T14:21:34Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

github-actions · 2023-03-20T16:14:35Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

github-actions · 2023-03-20T16:16:22Z

🤖 Beep Boop! Matrix Testing for this PR has been initiated. Please check back later for results.

💡 If you do not hear back from me please check my status! I will report even if this PR does not contain files eligible for matrix testing.

jsinglet · 2023-03-20T16:16:31Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


PACKAGE              : IO2
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True
SUITE                : CERT-C
TEST_DIFFERENCE      : 
TEST_PASS            : True
QUERY                : DoNotCopyAFileObject
RULE                 : FIO38-C

jsinglet · 2023-03-20T16:18:07Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:18:11Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:18:15Z

🤖 Beep Boop! clang/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:18:18Z

🤖 Beep Boop! gcc/cpp/X86_64 Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:18:20Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:18:30Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
PACKAGE              : IO2
COMPILE_PASS         : True
RULE                 : FIO38-C
SUITE                : CERT-C
TEST_PASS            : True
QUERY                : DoNotCopyAFileObject

jsinglet · 2023-03-20T16:18:43Z

🤖 Beep Boop! clang/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
SUITE                : CERT-C
QUERY                : DoNotCopyAFileObject
RULE                 : FIO38-C
TEST_PASS            : True
PACKAGE              : IO2
COMPILE_ERROR_OUTPUT : 
COMPILE_PASS         : True

jsinglet · 2023-03-20T16:18:52Z

🤖 Beep Boop! gcc/c/X86_64 Matrix Testing for this PR has been completed. See below for the results!


TEST_DIFFERENCE      : 
QUERY                : DoNotCopyAFileObject
TEST_PASS            : True
SUITE                : CERT-C
COMPILE_PASS         : True
PACKAGE              : IO2
RULE                 : FIO38-C
COMPILE_ERROR_OUTPUT :

jsinglet · 2023-03-20T16:19:42Z

🤖 Beep Boop! qcc/cpp/AARCH64LE Matrix Testing for this PR has been completed but I didn't find anything to test!

jsinglet · 2023-03-20T16:21:32Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


QUERY                : DoNotCopyAFileObject
RULE                 : FIO38-C
COMPILE_PASS         : True
PACKAGE              : IO2
COMPILE_ERROR_OUTPUT : 
TEST_PASS            : True
TEST_DIFFERENCE      : 
SUITE                : CERT-C

jsinglet · 2023-03-20T16:21:49Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet · 2023-03-20T16:23:18Z

🤖 Beep Boop! qcc/c/AARCH64LE Matrix Testing for this PR has been completed. See below for the results!


COMPILE_PASS         : True
SUITE                : CERT-C
PACKAGE              : IO2
TEST_PASS            : True
RULE                 : FIO38-C
COMPILE_ERROR_OUTPUT : 
TEST_DIFFERENCE      : 
QUERY                : DoNotCopyAFileObject

jsinglet · 2023-03-20T16:23:40Z

🤖 Beep Boop! Matrix Testing for this PR has been completed. If no reports were posted it means this PR does not contain things that need matrix testing!

jsinglet

LGTM

Fix compilation issue with qcc

cbb5423

mbaluda self-assigned this Mar 15, 2023

Update test.c.qcc

3df370a

github deleted a comment from jsinglet Mar 15, 2023

mbaluda marked this pull request as ready for review March 15, 2023 22:54

mbaluda requested a review from jsinglet March 15, 2023 22:55

mbaluda enabled auto-merge March 16, 2023 22:21

lcartey reviewed Mar 17, 2023

View reviewed changes

c/cert/test/rules/FIO38-C/test.c.qcc Outdated Show resolved Hide resolved

Remove test f2b from FIO38-C tests

68f0caa

Merge branch 'main' into mbaluda-qcc-fio38-c

dedc330

mbaluda requested a review from lcartey March 20, 2023 11:34

mbaluda changed the title ~~Fix compilation issue with qcc for FIO38-C~~ Remove failing test for FIO38-C Mar 20, 2023

Update build_test_database.py

cb6c97d

Delete settings.json

0fda6b7

jsinglet approved these changes Mar 23, 2023

View reviewed changes

mbaluda added this pull request to the merge queue Mar 23, 2023

Merged via the queue into github:main with commit 8a9c3be Mar 23, 2023

mbaluda deleted the mbaluda-qcc-fio38-c branch March 23, 2023 20:11

Remove failing test for FIO38-C #255

Remove failing test for FIO38-C #255

Uh oh!

Conversation

mbaluda commented Mar 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change request type

Rules with added or modified queries

Release change checklist

Query development review checklist

Author

Reviewer

Uh oh!

github-actions bot commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

github-actions bot commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

jsinglet commented Mar 15, 2023

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

github-actions bot commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

Uh oh!

jsinglet commented Mar 20, 2023

mbaluda commented Mar 15, 2023 •

edited

Loading