Skip to content

Michaelrfairhurst/compatible types performance fix alt #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix private predicate
  • Loading branch information
MichaelRFairhurst committed Apr 27, 2025
commit 80a40772296cb0436398f590bd9575f9aa1f1de2
2 changes: 1 addition & 1 deletion cpp/common/src/codingstandards/cpp/types/Compatible.qll
Original file line number Diff line number Diff line change
@@ -286,7 +286,7 @@ module TypeEquivalence<TypeEquivalenceSig Config, interestedInEquality/2 interes
* This only holds if the specified predicate `interestedIn` holds for the types, and always
* holds if `t1` and `t2` are identical.
*/
private predicate equalTypes(Type t1, Type t2) {
predicate equalTypes(Type t1, Type t2) {
compares(pragma[only_bind_into](t1), pragma[only_bind_into](t2)) and
if Config::overrideTypeComparison(t1, t2, _)
then Config::overrideTypeComparison(t1, t2, true)
Loading
Oops, something went wrong.