Skip to content

Java: Location.getFile().getAbsolutePath() contains Windows drive letter for non-source classes #5712

Open
@Marcono1234

Description

@Marcono1234

Version

CodeQL CLI version 2.5.0

Description

For types which are not part of the source, Location.getFile().getAbsolutePath() returns a path which contains the Windows drive letter.
For tests which have the path (as part of the URL) in their expected output this therefore results in test failures on Windows.
For example if I run on Windows the test added by #5711 it fails due to the file URL mismatch.

However, it looks like there are no existing tests in this repository with non-source types in their exepcted output, and CodeQL CLI explicitly warns about this:

Locations outside the test directory do not work well for regression tests.

Though it is still rather weird why the Windows drive letter is included in the first place.

Example

Code QL query:

import java

from TypeObject t
select t, t.getLocation().getFile().getAbsolutePath()

Under Windows with the database being under C:\... the result is: C:/modules/java.base/java/lang/Object.class
Under Linux the result is: /modules/java.base/java/lang/Object.class

(Note: For some demo projects the path is /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/rt.jar/java/lang/Object.class (Query Console link); I am not sure on what this depends and whether this could cause issues for other users as well)

Metadata

Metadata

Assignees

No one assigned

    Labels

    JavaquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions