LGTM.com - false positive cs/constant-condition

[rkm]

Conditions including true && ... are falsely reported as always returning true.

While I admit including extra true statements is a bit redundant, it can help minimise git diffs when long conditionals are split over multiple lines.

https://lgtm.com/projects/g/rkm/lgtm-constant-conditional-test

Thanks!

[hvitved]

Hi

The query does not actually flag the whole condition as always true, but rather only the true part of true && .... You will notice this when you hover over the red bar containing the alert text Condition always evaluates to 'true'..

I also don't quite understand why the true && prefix helps when splitting complex conditionals over multiple lines, why not simply

return A
    && B
    && C

or

return
    A
    && B
    && C

[hmakholm]

I also don't quite understand why the true && prefix helps when splitting complex conditionals over multiple lines

I think the reporter's point was that in each of your alternative proposals, one would need modify the line containing B if one decided to remove the A conjunct from the condition. So that line would show up as "changed" in a git diff.