JavaScript: Add model of JSON parsers #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@xiemaisi to answer your question from before, I've run a full evaluation. I've included the links this time. |
nickrolfe
pushed a commit
to nickrolfe/codeql
that referenced
this pull request
Aug 6, 2018
…-candidates JavaScript: support optimistic tracking of arrow route handlers
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
DB scheme: convert uppercase to lowercase + underscore
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Add gitignore
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
feat(field-flow): Refactor flow through job outputs
nicolaswill
added a commit
that referenced
this pull request
May 12, 2025
Initial progress on key agreement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
JsonParserCallwhich models a call to a JSON parser.JsonParseCallto avoid confusion.JSON.parsehas been updated to includeJsonParserCall.NosqlInjectionquery used two-pass taint tracking to identify user-controlledJSON.parsecalls, and then use those as sources. This was redundant with the taint step throughJSON.parse, however. This has been removed, instead relying on the standard taint step. I've added a test to make sure it still works. In theory, some results may disappear since the two-step solution technically allowed for mismatched call/returns.The evaluation indicates no changes; maybe a slight speed-up even due to
NosqlInjection. The speed-up could be covering up a slow-down elsewhere, but looking over the per-query results there doesn't seem to be any glaring slow-downs. No new results were flagged.