Fix partial path traversal Java example #11899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Java recommendation example for the "Partial path traversal vulnerability from remote" query doesn't seem right to me. Indeed, the following statement doesn't compile, since `dir.getCanonicalPath()` returns a String: ``` dir.getCanonicalPath().toPath() ``` Maybe the author wanted to state `dir.getCanonicalFile().toPath()`, which would compile, but is useless compared to `dir.getCanonicalPath()`. Moreover, `parent.getCanonicalFile().toPath()` or `parent.getCanonicalPath()` will **not** be slash-terminated, contrary to what the description says. From what I can see (and test), the correct fix is to concatenate `File.separator` to the parent canonical path.
atorralba
approved these changes
Jan 17, 2023
There was a problem hiding this comment.
Good catch! Your suggestion is also consistent with the test cases, so I'd say you're right. Thanks for your contribution!
|
QHelp previews: |
smowton
approved these changes
Jan 17, 2023
|
This isn't correct. This should have used |
|
Resolved by #12735 |
JLLeitschuh
added a commit
to JLLeitschuh/ql
that referenced
this pull request
Mar 31, 2023
The original wouldn't compile, and the fix made by github#11899 is sub-optimal. This keeps the entire comparision using the Java `Path` object, which is optimal. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
JLLeitschuh
added a commit
to JLLeitschuh/ql
that referenced
this pull request
Mar 31, 2023
The original wouldn't compile, and the fix made by github#11899 is sub-optimal. This keeps the entire comparision using the Java `Path` object, which is optimal. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
JLLeitschuh
added a commit
to JLLeitschuh/ql
that referenced
this pull request
Mar 31, 2023
The original wouldn't compile, and the fix made by github#11899 is sub-optimal. This keeps the entire comparision using the Java `Path` object, which is optimal. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
JLLeitschuh
added a commit
to JLLeitschuh/ql
that referenced
this pull request
Apr 1, 2023
The original wouldn't compile, and the fix made by github#11899 is sub-optimal. This keeps the entire comparision using the Java `Path` object, which is optimal. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
JLLeitschuh
added a commit
to JLLeitschuh/ql
that referenced
this pull request
Apr 1, 2023
The original wouldn't compile, and the fix made by github#11899 is sub-optimal. This keeps the entire comparision using the Java `Path` object, which is optimal. Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
|
Thanks @JLLeitschuh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Java recommendation example for the "Partial path traversal vulnerability from remote" query doesn't seem right to me. Indeed, the following statement doesn't compile, since
dir.getCanonicalPath()returns a String:Maybe the author wanted to state
dir.getCanonicalFile().toPath(), which would compile, but is useless compared todir.getCanonicalPath().Moreover,
parent.getCanonicalFile().toPath()orparent.getCanonicalPath()will not be slash-terminated, contrary to what the description says. From what I can see (and test), the correct fix is to concatenateFile.separatorto the parent canonical path.This is linked to #9742.