Simplify C locations handling #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
pushed a commit
to nickrolfe/codeql
that referenced
this pull request
Aug 6, 2018
JavaScript: cryptographic keys as sinks for js/insecure-randomness
|
Profiling still going on; this is likely to pick up a few more changes and tweaks shortly. |
pavgust
added
WIP
pavgust
force-pushed
the
imp/c-locations
branch
2 times, most recently
from
1bef161 to
41a36e1
Compare
|
@jbj Profiling looks good, results unchanged. I think this is good to go. |
pavgust
force-pushed
the
imp/c-locations
branch
from
41a36e1 to
628edc9
Compare
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Use tree-sitter-ruby crate instead of vendoring it
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Oct 28, 2021
Kotlin: Use a TrapWriter for the invocation TRAP
hohn
pushed a commit
to hohn/codeql
that referenced
this pull request
Dec 13, 2021
SQL Injection Java Workshop
RasmusWL
pushed a commit
that referenced
this pull request
May 30, 2022
Move tests back into `frameworks/` folder
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
feat(bash-step): Improve bash step accuracy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit simplifies the various bits of location handling to refer to a shared new predicate (
Location::fullLocationInfo, which is likehasLocationInfo/5but exposes the actual container entity). This avoids a certain amount of repetition, as all the predicates that explicitly called the threelocations_*tables can now just refer to the single place that unions those tables.The second commit is a minor simplification to
defintions.qll, following recent changes to location handling (and more things becomingContainers rather thanFiles). In particular, it allows us to find a much better way of evaluating that part of the predicate.