Skip to content

JavaScript: Generalize description of js/unused-local-variable. #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2018

Conversation

xiemaisi
Copy link

@xiemaisi xiemaisi commented Aug 6, 2018

The query also flags unused imports, functions and classes (which, of course, are just unused variables at the end of the day). This is now made more explicit in the description.

The query also flags unused imports, functions and classes (which, of course, are just unused variables at the end of the day). This is now made more explicit in the description.
nickrolfe pushed a commit to nickrolfe/codeql that referenced this pull request Aug 6, 2018
JavaScript: Move analysis change notes to submodule.
@ghost ghost self-requested a review August 7, 2018 05:53
@ghost
Copy link

ghost commented Aug 7, 2018

LGTM.
Ping @Semmle/doc for a minor review.

@mchammer01
Copy link
Contributor

Thanks for the mention (will take a look after lunch)

@mchammer01
Copy link
Contributor

LGTM, this can be merged from a documentation point of view.

@semmle-qlci semmle-qlci merged commit 4d97570 into github:master Aug 7, 2018
@xiemaisi xiemaisi deleted the js/rename-unused-var branch August 13, 2018 09:18
tamasvajk referenced this pull request in tamasvajk/codeql Sep 16, 2021
Kotlin: Pull TrapWriter out into its own file
aibaars added a commit that referenced this pull request Oct 14, 2021
TRAP locations: always fix-up empty ranges
erik-krogh referenced this pull request in erik-krogh/ql Dec 15, 2021
Add the `ql/primary-ql-class-consistency` query
erik-krogh referenced this pull request in erik-krogh/ql Dec 15, 2021
Add the `ql/primary-ql-class-consistency` query
dbartol pushed a commit that referenced this pull request Dec 18, 2024
feat(reusable-workflow-models): Reusable workflow MaD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants