Skip to content

Add code quality suite selector and use that in the code quality suites #19413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use code-quality-selectors in Python suite
  • Loading branch information
tamasvajk committed Apr 29, 2025
commit fdeac95714f4db728fe64c23e53ff6b8aee4d66f
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
ql/python/ql/src/Functions/NonCls.ql
ql/python/ql/src/Functions/NonSelf.ql
ql/python/ql/src/Functions/ReturnConsistentTupleSizes.ql
ql/python/ql/src/Functions/SignatureSpecialMethods.ql
ql/python/ql/src/Resources/FileNotAlwaysClosed.ql
ql/python/ql/src/Variables/LoopVariableCapture/LoopVariableCapture.ql
1 change: 1 addition & 0 deletions python/ql/src/Functions/NonCls.ql
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@
* @tags maintainability
* readability
* convention
* quality
* @problem.severity recommendation
* @sub-severity high
* @precision high
1 change: 1 addition & 0 deletions python/ql/src/Functions/NonSelf.ql
Original file line number Diff line number Diff line change
@@ -5,6 +5,7 @@
* @tags maintainability
* readability
* convention
* quality
* @problem.severity recommendation
* @sub-severity high
* @precision very-high
8 changes: 2 additions & 6 deletions python/ql/src/codeql-suites/python-code-quality.qls
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
- queries: .
- include:
id:
- py/not-named-self
- py/not-named-cls
- py/file-not-closed
- py/special-method-wrong-signature
- apply: code-quality-selectors.yml
from: codeql/suite-helpers