-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Set CWE-134 from 9.3 to 7.3 CVSS score for memory safe languages #19530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Sync up to score given to javascript/ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aligns the @security-severity
rating for uncontrolled format string queries in memory-safe languages with existing JavaScript/Ruby rules by lowering it from 9.3 to 7.3.
- Reduced severity score in Swift, Java, and C# queries to 7.3
- Ensures consistency across supported memory-safe languages
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
swift/ql/src/queries/Security/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql | Updated @security-severity from 9.3 to 7.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swift 👍
Worth a changenote here or
no-change-note-required
|
It should have a change note. There is a guide here. It should be a query change note, with the category "queryMetadata". |
53a6133
Change notes added 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java LGTM
I don't know why the frameworks coverage artifacts CI job failed. I've restarted it. If it runs successfully then it won't find anything interesting for this PR, so if it fails again I don't think it should block this PR. |
It's complaining about something related to the PR though. Are the line endings of the Swift change note Unix line endings? Error is:
|
This pull request adjusts the
@security-severity
level for several queries related to uncontrolled format strings across memory safe languages to better reflect their impact. The risk is limited to application crashes or information disclosure, not system compromise. The severity has been reduced from9.3
to7.3
to match up to the similar Javascript / Ruby queries.codeql/javascript/ql/src/Security/CWE-134/TaintedFormatString.ql
Line 6 in e6235a5
codeql/javascript/ql/src/experimental/heuristics/ql/src/Security/CWE-134/TaintedFormatString.ql
Line 6 in e6235a5
codeql/ruby/ql/src/queries/security/cwe-134/TaintedFormatString.ql
Line 6 in e6235a5